Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid setting batched before the class is initialized #5814

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Avoid setting batched before the class is initialized #5814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions holoviews/plotting/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,7 +1164,6 @@ def __init__(self, element, keys=None, ranges=None, dimensions=None,
self.zorder = zorder
self.cyclic_index = cyclic_index
self.overlaid = overlaid
self.batched = batched
self.overlay_dims = overlay_dims

if not isinstance(element, (HoloMap, DynamicMap)):
Expand All @@ -1179,7 +1178,7 @@ def __init__(self, element, keys=None, ranges=None, dimensions=None,
self.stream_sources = compute_overlayable_zorders(self.hmap)

plot_element = self.hmap.last
if self.batched and not isinstance(self, GenericOverlayPlot):
if batched and not isinstance(self, GenericOverlayPlot):
plot_element = plot_element.last

dynamic = isinstance(element, DynamicMap) and not element.unbounded
Expand All @@ -1203,6 +1202,7 @@ def __init__(self, element, keys=None, ranges=None, dimensions=None,
self.param.warning(self._deprecations[p])
super().__init__(keys=keys, dimensions=dimensions,
dynamic=dynamic, **applied_params)
self.batched = batched
self.streams = get_nested_streams(self.hmap) if streams is None else streams

# Attach streams if not overlaid and not a batched ElementPlot
Expand Down