Prevent edge cases in XArrayInterface from crashing #5809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes holoviz/geoviews#663 and #4910
The examples in the issues above no longer crashes. I suspect datashade was peddling numpy arrays into XArrayInterface, but there was no handling for that so this PR implements that.
Also, there was NaNs in the bounds and casting to int raised an exception; this simply sets NaNs to 0s to prevent it from crashing.