Prevent edge cases in XArrayInterface from crashing #5809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5809 +/- ##
==========================================
+ Coverage 88.15% 88.17% +0.02%
==========================================
Files 307 307
Lines 62908 62916 +8
==========================================
+ Hits 55459 55479 +20
+ Misses 7449 7437 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hoxbro
reviewed
Jul 14, 2023
hoxbro
reviewed
Jul 14, 2023
hoxbro
approved these changes
Jul 14, 2023
|
LGTM. Thank you for the fix 👍 |
|
Cool 😎 no problem! This bug had me do work arounds 2 years ago; I'm glad it's finally fixed haha |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes holoviz/geoviews#663 and #4910
The examples in the issues above no longer crashes. I suspect datashade was peddling numpy arrays into XArrayInterface, but there was no handling for that so this PR implements that.
Also, there was NaNs in the bounds and casting to int raised an exception; this simply sets NaNs to 0s to prevent it from crashing.