Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FileArchive repr for Param 2.0 #5791

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Update FileArchive repr for Param 2.0 #5791

merged 1 commit into from
Jul 4, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jul 2, 2023

Seen with @jlstevens when reviewing holoviz/param#767, there was a remaining call to Parameterized.pprint that is going to be removed in Param 2.0. It's replaced by Parameterized.param.pprint that has been available since Param 1.12.0, 1.12.0 being the minimum version required by HoloViews currently so there's no need for any compatibility code.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

Merging #5791 (a64cfc5) into main (3f97338) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #5791   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files         307      307           
  Lines       62850    62850           
=======================================
  Hits        55401    55401           
  Misses       7449     7449           
Flag Coverage Δ
ui-tests 22.41% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
holoviews/core/io.py 80.34% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro
Copy link
Member

hoxbro commented Jul 4, 2023

LGTM

@hoxbro hoxbro merged commit bcdfae6 into main Jul 4, 2023
@hoxbro hoxbro deleted the update_pprint_param2 branch July 4, 2023 09:28
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants