Deprecate functionality #5776
Merged
Deprecate functionality #5776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5776 +/- ##
==========================================
- Coverage 88.14% 88.14% -0.01%
==========================================
Files 307 307
Lines 62850 62854 +4
==========================================
+ Hits 55401 55403 +2
- Misses 7449 7451 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
philippjfr
approved these changes
Jul 6, 2023
philippjfr
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
This looks good.
py2jswas removed in Bokeh looong ago and is not maintained so removing it is the only sensible move.ResamplingOperationwas already deprecatedBoundingRegionParameterwas almost certainly never used by anything, it got inherited from topographica and is some of the oldest code in HoloViews
Merged
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecated two items:
BoundingRegionParameteras discussed herepy2js_tickformatter(which we are not even testing right now)pscript#5327I also bumped ResamplingOperation to 1.18.