-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up import time #5719
Speed up import time #5719
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5719 +/- ##
=======================================
Coverage 88.24% 88.24%
=======================================
Files 304 305 +1
Lines 62680 62693 +13
=======================================
+ Hits 55309 55324 +15
+ Misses 7371 7369 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Only question from my side is why you had to make IPython imports lazy in |
Good catch. I think I made those changes before I added the sys.module change. I have reverted it now. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The main focus is to get the import time down. Done with
python -X importtime -c "import holoviews" 2> log.txt && tuna log.txt
For now, I have moved IPython, Ibis, and Panel to be lazy imports.
Current main (taking 1.256 seconds to load):
With this PR (takes 0.338 seconds to load):