-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the bounds of the kdims
List parameter
#5667
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5667 +/- ##
==========================================
- Coverage 88.29% 88.29% -0.01%
==========================================
Files 302 302
Lines 62541 62541
==========================================
- Hits 55220 55219 -1
- Misses 7321 7322 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@hoxbro this could be merged safely, and need to be merged not to break HoloViews with Param 2.0. |
Thank you for this 👍 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
I just ran the unit test suite of HoloViews with Param installed from holoviz/param#605 and a few tests failed. They failed when
kdims
List
is overridden in a sub Parameterized class, and the overridingList
is not defining explicitly the newbounds
. In the current state of Param (1.x) ,bounds
is not inherited from any super class but is always the default of(0, None)
(meaning a list of any length). With the tested PRbounds
is inherited.The change made in this PR was to set explicitly the
bounds
in the subclasses. Alternatively, one could have loosenbounds
in the super classes. The commits list what change was made and why. For instance, one could have setbounds
ofChart.kdims
(super class) to(0, None)
instead of updatingbounds
onSpikes.kdims
(sub class) to(0, None)
. I didn't spend much time thinking about doing the alternativeI noticed there are a few typos in the commits, here are the changes made:
(0,None)
toSpikes.vdims
to overrideChart.vdims
bounds of(1, None)
(3,3)
toPath3D.vdims
to overrideGeometry.vdims
bounds of(2, 2)
(3,3)
toScatter3D.vdims
to overrideGeometry.vdims
bounds of(2, 2)
(3,3)
toTriSurface.vdims
to overrideGeometry.vdims
bounds of(2, 2)