-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure rangesupdate event fires on all plots with linked axes #5465
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5465 +/- ##
=======================================
Coverage 88.12% 88.12%
=======================================
Files 301 301
Lines 62104 62108 +4
=======================================
+ Hits 54730 54734 +4
Misses 7374 7374
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Will push a fix later. |
Odd, there is the following error, but only on 3.9 ubuntu?! def test_poly_edit_callback(self):
polys = Polygons([[(0, 0), (2, 2), (4, 0)]])
poly_edit = PolyEdit(source=polys)
plot = bokeh_server_renderer.get_plot(polys)
> self.assertIsInstance(plot.callbacks[0], PolyEditCallback)
E AssertionError: <holoviews.plotting.bokeh.callbacks.PolyDrawCallback object at 0x7efd2eb31340> is not an instance of <class 'holoviews.plotting.bokeh.callbacks.PolyEditCallback'> |
Nothing to do with this PR, has been a transient for over a year now. |
I was wondering if it was a transient but I never realized we had one that was an Anyway, merging. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes #5381