Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure setting opts on DynamicMap does not generate deprecation warnings #5345

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 27, 2022

The DynamicMap._style method is responsible for applying options set on a DynamicMap. It does so by looking up a custom options tree and then setting that on the returned object. The format of that custom options tree is broken down by the options group (i.e. 'style', 'norm' and 'plot') and then gets applied using the public .opts() call. This is problematic because .opts explicitly checks that options are not set using the deprecated option groups format. Therefore we bypass that call and directly apply the option groups using opts.apply_groups (which is what happens internally anyway).

Fixes #5341

@jlstevens
Copy link
Contributor

Thanks for the clear explanation and the change looks fine. Happy to see this merged when the tests pass.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2022

Codecov Report

Merging #5345 (c952280) into master (39d7bf1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5345   +/-   ##
=======================================
  Coverage   88.07%   88.08%           
=======================================
  Files         301      301           
  Lines       61976    61977    +1     
=======================================
+ Hits        54587    54590    +3     
+ Misses       7389     7387    -2     
Impacted Files Coverage Δ
holoviews/core/spaces.py 84.67% <100.00%> (+0.01%) ⬆️
holoviews/tests/plotting/bokeh/test_renderer.py 99.39% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39d7bf1...c952280. Read the comment docs.

@philippjfr philippjfr merged commit 5392a11 into master Jun 27, 2022
@philippjfr philippjfr deleted the dmap_style_apply_fix branch June 27, 2022 11:34
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rasterize with opts raises warning in latest dev release
3 participants