Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Dimension to accept a dict spec #5333

Merged
merged 9 commits into from
Oct 15, 2022
Merged

Enable Dimension to accept a dict spec #5333

merged 9 commits into from
Oct 15, 2022

Commits on Jul 14, 2022

  1. Add failing tests of specifying Dimension with dict 

    Also test constructing MultidimensionalMapping with kdim given as dict.
    @stanwest
    stanwest committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    102ae2e View commit details
    Browse the repository at this point in the history

  2. Look up preset Dimension only with str spec 

    Enables specifying Dimension with dict containing name and label.
    @stanwest
    stanwest committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    85f9f42 View commit details
    Browse the repository at this point in the history

  3. Require "name" key in Dimension dict 

    Also, use name as default label.
    @stanwest
    stanwest committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    46af270 View commit details
    Browse the repository at this point in the history

  4. Consolidate handling of types of Dimension specs

    @stanwest
    stanwest committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    df5ee69 View commit details
    Browse the repository at this point in the history

  5. Gather params into one dict instead of two

    @stanwest
    stanwest committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    b5cd405 View commit details
    Browse the repository at this point in the history

  6. Allow wrong types to fall through to param checks 

    Let the param system handle (1) a non-string name or label within a
tuple and (2) a non-hashable label, which previously raised "TypeError:
unhashable type" at the membership check.
    @stanwest
    stanwest committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    9a21842 View commit details
    Browse the repository at this point in the history

  7. Improve handling of name and label in tuple

    @stanwest
    stanwest committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    c47b043 View commit details
    Browse the repository at this point in the history

  8. Raise when calling Dimension with invalid type 

    Two helper functions no longer need to raise such an exception.
    @stanwest
    stanwest committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    fcb3180 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Reformat parenthesis

    @stanwest
    stanwest committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    af4b20a View commit details
    Browse the repository at this point in the history