-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test suite clean up and fix for the pip build #5326
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5326 +/- ##
==========================================
+ Coverage 86.64% 88.00% +1.36%
==========================================
Files 299 299
Lines 62227 61849 -378
==========================================
+ Hits 53917 54432 +515
+ Misses 8310 7417 -893
Continue to review full report at Codecov.
|
I've manually launched the docs and the packages workflows in dry-run mode and they succeeded, merging then. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This turned into a bigger PR than I thought. My original intention was to fix the pip build that appeared to be broken when it last run on the scheduled jobs. I saw that the grouped dependencies in
setup.py
where not so clear, so started to re-organize them and checked in particular the ones required to run the tests (not the notebooks). That led me to simplify a lot of imports in the tests. For instance in many placespandas
was assumed to be optional while it's now a required dependency of HoloViews, same for Panel. The tests also now need Bokeh, Matplotlib and Plotly to be installed to run. This made sense to me, they're so critical to HoloViews.