Ensure overlay_aggregate is not applied for anti-aliased lines #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5266 +/- ##
==========================================
- Coverage 86.72% 86.71% -0.01%
==========================================
Files 299 299
Lines 62187 62189 +2
==========================================
+ Hits 53929 53930 +1
- Misses 8258 8259 +1
Continue to review full report at Codecov.
|
jbednar
reviewed
Apr 8, 2022
| if not self.applies(element, agg_fn, line_width=self.p.line_width): | ||
| raise ValueError( | ||
| 'overlay_aggregate only handles aggregation of NdOverlay types ' | ||
| 'with count, sum or mean reduction.' |
There was a problem hiding this comment.
Suggested change
| 'with count, sum or mean reduction.' | |
| 'with count, sum, any, or mean reduction.' |
philippjfr
added a commit
that referenced
this pull request
Apr 10, 2022
* Ensure overlay_aggregate is not applied for anti-aliased lines * Small fixes
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization does not work for anti-aliased curves.