Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting line_width on datashader line aggregation #5264

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 7, 2022

Adds support for setting line_width on datashader aggregation operations if datashader version >= 0.14.

Also adds support for rescale_discrete_levels option on shade operation.

@philippjfr philippjfr added the backport PRs which are to land in a hotfix release label Apr 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #5264 (093d330) into master (e3af887) will decrease coverage by 0.00%.
The diff coverage is 80.95%.

@@            Coverage Diff             @@
##           master    #5264      +/-   ##
==========================================
- Coverage   86.75%   86.75%   -0.01%     
==========================================
  Files         298      298              
  Lines       62162    62176      +14     
==========================================
+ Hits        53929    53939      +10     
- Misses       8233     8237       +4     
Impacted Files Coverage Δ
holoviews/operation/datashader.py 80.00% <80.95%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3af887...093d330. Read the comment docs.

@jlstevens
Copy link
Contributor

Tests are passing so feel free to merge if you think this is ready.

@philippjfr philippjfr merged commit 945b1f5 into master Apr 8, 2022
@maximlt maximlt deleted the ds_line_width branch May 3, 2022 16:28
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport PRs which are to land in a hotfix release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants