-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading JS once in the given cell #5249
Conversation
Does not seem sufficient, you'll also have to handle these lines:
and we probably also need to think about adding warning checking that if |
Codecov Report
@@ Coverage Diff @@
## master #5249 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 298 298
Lines 62159 62162 +3
=======================================
+ Hits 53926 53929 +3
Misses 8233 8233
Continue to review full report at Codecov.
|
I've merged master and the tests all passed 🎉 Ready to be merged then I think @jlstevens |
Thanks for fixing the tests! @philippjfr please merge if you think this PR is ready. |
* Only loading JS once in the same cell * Made resource loading conditional on saml_cell_execution * Fixed definition of same_cell_execution Co-authored-by: maximlt <mliquet@anaconda.com>
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
PR using the information now exposed in holoviz/pyviz_comms#87 to avoid repeatedly loading JS in the same cell (e.g. if multiple extensions are in the first cell of a notebook).