use Renderer's center property for HoloViews pane #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I noticed that there are 2 places where HoloViewsPane is instantiated: in one case its center property is set using Renderer's center property, in another it is set to always = True, not sure if this is intended behavior, but I assume this should be fixed, as currently you need to wrap you plot into panel manually if you don't want to center it, which is a bit inconvenient.
|
Thanks @stas-sl! |
|
Oops 😳, now it should be better |
|
Hmm, I'm not sure now how the error could be caused by my changes, but if so, probably it is more complicated than I thought... |
philippjfr
pushed a commit
that referenced
this pull request
Apr 8, 2022
* use Renderer's center property for HoloViews pane Hi, I noticed that there are 2 places where HoloViewsPane is instantiated: in one case its center property is set using Renderer's center property, in another it is set to always = True, not sure if this is intended behavior, but I assume this should be fixed, as currently you need to wrap you plot into panel manually if you don't want to center it, which is a bit inconvenient. * use Renderer's center property for HoloViews pane
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that there are 2 places where HoloViewsPane is instantiated: in one case its center property is set using Renderer's center property, in another it is set to always = True, not sure if this is intended behavior, but I assume this should be fixed, as currently you need to wrap you plot into panel manually if you don't want to center it, which is a bit inconvenient.