-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to deploy the docs #5087
Conversation
Happy to merge whenever you say it is ready (now I've seen it build and the output looks good). That said, I suppose it is worth testing the manual trigger first... |
d6e3563
to
c9a3fe2
Compare
@jlstevens I squashed some commits and forced push. And created a new 1.14.7 branch against which this PR is now on. I've also removed the 1.14.6a4 dummy tag I used to trigger the docs build. The manual trigger button doesn't appear as of yet. I have in mind that once this is merged it should appear. |
I believe what should happen is this:
That way the doc fix here is on both master and the 1.14.7 hotfix. @philippjfr Do you agree? In other words, if this PR is rebased against master, I am happy to go ahead and merge! I am happy to open the 1.14.7 PR and do the cherry pick after the merge. |
Yes, that's the correct approach, generally things should land on master first and backported if needed. Indeed I suggest we create a |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Currently
ibis-framework
cannot be installed on Ubuntu from conda-forge (conda-forge/ibis-framework-feedstock#54), yet it can be installed from defaults.The only dependency that is not available on defaults from the
-o doc
option is awscli. It's thus removed fromsetup.py
and installed afterdevelop install
from conda-forge. Note this is already done for selenium and geckodriver. After this change,develop_install
won't rely on conda-forge anymore.This PR also adds the possibility to trigger the docs workflow manually from the UI (https://github.blog/changelog/2020-07-06-github-actions-manual-triggers-with-workflow_dispatch/).