Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spatialpandas DaskGeoDataFrame #4792

Merged
merged 18 commits into from
Jan 21, 2021
Merged

Support spatialpandas DaskGeoDataFrame #4792

merged 18 commits into from
Jan 21, 2021

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 16, 2021

Adds support for DaskGeoDataFrame to the SpatialpandasInterface.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward, thanks! I'll test it out.

@jbednar
Copy link
Member

jbednar commented Jan 17, 2021

Seems to work, but only if I add , datatype=["spatialpandas"]. Any chance that the datatype can be detected automatically? Otherwise I think a lot of people will just assume it doesn't work.

@philippjfr
Copy link
Member Author

Of course but this isn't yet particularly close to being mergable.

@jlstevens
Copy link
Contributor

This screenshot demonstrates an issue with spatial pandas support that I hope this PR can help address:

image

@jlstevens
Copy link
Contributor

For what it is worth, I see the same problem as shown in the screenshot above when converting to geopandas.

@jbednar
Copy link
Member

jbednar commented Jan 20, 2021

@philippjfr philippjfr merged commit f799824 into master Jan 21, 2021
@philippjfr philippjfr deleted the dask_spatialpandas branch April 25, 2022 14:37
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants