-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Params support for unwatching #4417
Conversation
Erase 'return self._file' statement
A test case that examines clear() method of FileArchive class of io.py
When clear == True allows archive auto clear
…d and add a call to clear
if watch: | ||
# Subscribe to parameters | ||
keyfn = lambda x: id(x.owner) | ||
for _, group in groupby(sorted(parameters, key=keyfn)): | ||
group = list(group) | ||
group[0].owner.param.watch(self._watcher, [p.name for p in group]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to consider making the body of this if watch
clause a separate watch
method.
Thanks for the changes, I'll merge for now. Refactoring can happen in a subsequent PR. I'll also be tagging a dev release shortly. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Just merging the code written by @analog-cbarber. Issue #4360