Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle log colormapper zero lower bound #4383

Merged
merged 12 commits into from
Apr 24, 2020
Merged

Handle log colormapper zero lower bound #4383

merged 12 commits into from
Apr 24, 2020

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 16, 2020

Ensures compatibility with changes to log colormapping and change to tuple palettes in bokeh 2.0.x

Also handles None in clim.

Fixes #4361
Fixes #4376

@jlstevens
Copy link
Contributor

Looks good to me! I think with an augmented warning message, this can be merged.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It works well in my tests, but notice that there is a change in behavior: zero pixels are now transparent, when previously they were at the bottom of the color scale. I've pushed a change to nytaxi_hover.py to fix the display in that case, but there are probably other cases in the HoloViews codebase, datashader codebase, and examples.pyviz.org that will need a similar fix. Also note that the behavior for zero pixels now differs between linear and log colormapping, as 0 is only transparent for log. That will be confusing for Datashader users, but seems unavoidable.

holoviews/core/util.py Show resolved Hide resolved
holoviews/plotting/bokeh/element.py Outdated Show resolved Hide resolved
holoviews/plotting/bokeh/element.py Show resolved Hide resolved
holoviews/plotting/bokeh/element.py Show resolved Hide resolved
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle log colormapping change in bokeh 2.0 cmap arguments not accepted as tuples
3 participants