Always warn for deprecated call #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably worth grepping the travis logs for the warning in case it was missed anywhere internally (doubt it!) |
|
Just to double check, you are aware that this is |
|
Even if the tests go green, this PR doesn't need to be merged just yet as we will probably have another minor release first. |
philippjfr
force-pushed
the
call_options_deprecation
branch
2 times, most recently
from
76628c5
to
a9cd6a3
Compare
|
I've restored the method and am now merging. The fact that we never actually enabled the warning means that we can't remove it yet. |
philippjfr
force-pushed
the
call_options_deprecation
branch
from
a9cd6a3
to
b2fdd4b
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the last release still had the warning behind the
util.config.future_deprecationsflag. This PR makes sure the warning is always issued so we can finally remove__call__immediately after the next release.