Static HTML Exporting #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
static_html
branch
from
659d1be
to
46fa5aa
Compare
philippjfr
force-pushed
the
static_html
branch
from
46fa5aa
to
5e4ce94
Compare
| 'css' and the main 'html'. | ||
| """ | ||
| cls_type = type(self) | ||
| renderers = (cls_type,) + cls_type.__bases__ |
There was a problem hiding this comment.
I'm not sure I understand the need for this approach. Why not use this sort of pattern?
class BaseClass(object):
js_dependencies = {'jquery':'url1'}
class Subclass(BaseClass):
js_dependencies = dict(BaseClass.js_dependencies, **{'d3':'url2'})Then you could use self.js_dependencies, self.css_dependencies etc and you'll be able to get all the dependencies directly from the class attribute without iterating through the class hierarchy like this. Maybe I am missing something here?
|
Looks good! Other than the commit comment above, it looks fine. The only thing I would want before merging are a couple of (simple) unit tests. |
philippjfr
force-pushed
the
static_html
branch
from
67f00fa
to
b4d9e83
Compare
|
Ok, now all the tests are passing (including the new ones) it is time to merge! |
jlstevens
added a commit
that referenced
this pull request
Dec 1, 2015
Added support for exporting static HTML from Renderers
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the suggestion for static HTML export in #282. It accepts an optional template argument with three optional fields js, css and html. It's not quite ready for merge but already works.