Improved handling of the bokeh root model and comm #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
force-pushed
the
root_handling
branch
from
5c1e970
to
3126c88
Compare
philippjfr
force-pushed
the
root_handling
branch
from
c5dccc6
to
c5a4774
Compare
philippjfr
force-pushed
the
root_handling
branch
from
4bcf3d8
to
2021e8b
Compare
|
Ready to review and merge. |
philippjfr
changed the title
jlstevens
reviewed
Oct 9, 2018
holoviews/plotting/plot.py
Outdated
| @@ -236,7 +236,7 @@ def __init__(self, keys=None, dimensions=None, layout_dimensions=None, | |||
| self.current_key = None | |||
| self.ranges = {} | |||
| self.renderer = renderer if renderer else Store.renderers[self.backend].instance() | |||
| self.comm = None | |||
| self.comm = params.pop('comm', None) | |||
There was a problem hiding this comment.
Why not make this an explicit keyword argument?
|
Looks good to me. Merging. |
philippjfr
added a commit
that referenced
this pull request
Oct 25, 2018
# Conflicts: # holoviews/plotting/bokeh/callbacks.py # holoviews/plotting/bokeh/plot.py
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On bokeh plots the root model is required to set up comm callbacks. Currently this is handled in some pretty terrible ways, e.g. after subplots set up a comm callback any layout plot or similar that is wrapping the plot has to then search and replace a placeholder root model id with the actual root model id. By allowing users to pass in a root model into a plot we can at least avoid having to replicate this logic on upstream libraries like
panel.Similarly this PR also allows passing in a
Comminstance, so that upstream libraries do not have to patch all plots manually.