Fixed bug streaming SpreadPlot data #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
philippjfr
commented
Aug 20, 2018
philippjfr
commented
- Fixes hv.Spread on streams.Buffer #2917
- Adds unit test
philippjfr
added
type: bug
|
Ready to merge. |
jlstevens
reviewed
Aug 20, 2018
| @@ -483,6 +483,8 @@ class SpreadPlot(ElementPlot): | |||
| style_opts = line_properties + fill_properties | |||
| _plot_methods = dict(single='patch') | |||
|
|
|||
| _stream_data = False # Plot does not support streaming data | |||
There was a problem hiding this comment.
This was very confusing until I realized this might refer to the bokeh use of the word 'streaming'.
|
Looks good. The comment would be clearer if it said '# Plot does not support continuous bokeh streaming' (or similar) but that is a very minor complaint. Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.