Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-finite range in datashader operations #2863

Merged
merged 3 commits into from
Jul 7, 2018
Merged

Conversation

philippjfr
Copy link
Member

Non-finite ranges in the datashader operation were being given special treatment by defining a fake range. This is incompatible with the bounds and density validation so just like the zero-range case it will now actually use an empty range.

Additionally this PR adds support for zero-ranges to the ImageInterface.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell.

@philippjfr philippjfr merged commit d33d5b7 into master Jul 7, 2018
@philippjfr philippjfr deleted the empty_ds_agg branch August 5, 2018 00:26
@philippjfr philippjfr added this to the v1.10.8 milestone Oct 25, 2018
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants