Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bokeh version import #2113

Closed
wants to merge 2 commits into from

Conversation

suvarchal
Copy link

fixes bokeh_version import otherwise leads to

line 422, in set_server_callback if self.on_events and bokeh_version >= '0.12.5': NameError: name 'bokeh_version' is not defined

atleast while serving a bokeh app.

bokeh_version was not imported,  causes problem at line 422, atleast when running bokeh app
@philippjfr
Copy link
Member

Thanks for catching this, I've already made the fix in #2112. This check is no longer needed, so I've just removed it. We'll likely merge the fix tomorrow and then release 1.9.1 with the fix on Sunday.

@philippjfr philippjfr closed this Nov 11, 2017
@suvarchal suvarchal deleted the fix_bokeh_version_import branch November 11, 2017 22:55
@suvarchal
Copy link
Author

thanks! my baby steps to atleast make some contribution.

@philippjfr
Copy link
Member

Your contribution was definitely appreciated, and really it's on us to provide some material for contributors to get started!

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants