Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table finalize hook fix and example #1711

Merged
merged 3 commits into from
Jul 14, 2017

Conversation

jordansamuels
Copy link
Contributor

@jordansamuels jordansamuels commented Jul 10, 2017

One solution to #1708

Jordan Samuels added 2 commits July 10, 2017 17:43
* add additional URL
* committing mostly to test failing Travis build
@jordansamuels
Copy link
Contributor Author

(My additional commits were in confusion as I forgot it's another PR that's failing the Travis build.)

@jlstevens
Copy link
Contributor

Thanks for this!

We started adding little feature examples just like this one in holoviews-contrib and we haven't yet found a new home for them (see this example which is very similar).

Discussing this with Philipp, we think this can be the first example in /examples/reference/features/bokeh. Could you please initialize those directories and move your example there?

@jlstevens jlstevens changed the title https://github.com/ioam/holoviews/issues/1708 Table finalize hook fix and example Jul 11, 2017
@jordansamuels
Copy link
Contributor Author

@jlstevens yes, will reorganize and add the example soon. Thanks.

@jlstevens
Copy link
Contributor

@jordansamuels Thanks!

PR looks good merging.

@jlstevens jlstevens merged commit 3035c7d into holoviz:master Jul 14, 2017
@jlstevens jlstevens added this to the 1.8.2 milestone Aug 21, 2017
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants