Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter style opts for plots not declaring style_opts #1438

Merged
merged 1 commit into from
May 15, 2017
Merged

Conversation

philippjfr
Copy link
Member

The logic here was slightly wrong in that plots can declare that they have no valid style_opts and filtering should still be applied.

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label May 15, 2017
@jlstevens
Copy link
Contributor

Looks good! Merge?

@philippjfr
Copy link
Member Author

Yes, ready to merge.

@jlstevens jlstevens merged commit 6eed7ea into master May 15, 2017
@philippjfr philippjfr deleted the style_filter branch May 25, 2017 11:40
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants