Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restored logo parameter and removed banner text #1291

Merged
merged 1 commit into from
Apr 14, 2017

Conversation

jlstevens
Copy link
Contributor

@jlstevens jlstevens commented Apr 14, 2017

This PR reverts the changes of PR #1231 after the discussion in issue #1186.

The logo switch has now been restored and the banner message disabled In HoloViews 2.0 we would like a logo per backend (or better, combine logos somehow?)

Here is the new behavior:

image

@jlstevens jlstevens changed the title Restored notebook_extension logo parameter and removed banner text Restored logo parameter and removed banner text Apr 14, 2017
@philippjfr
Copy link
Member

Looks good, merging.

@philippjfr philippjfr merged commit d460fa0 into master Apr 14, 2017
@jbednar jbednar deleted the restore_logo_option branch April 14, 2017 02:13
@jbednar
Copy link
Member

jbednar commented Apr 14, 2017

Excellent; thanks so much!

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants