Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh widgets editable #1247

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Bokeh widgets editable #1247

merged 1 commit into from
Apr 7, 2017

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 7, 2017

Adds an editable option, which is False by default to improve the look of the widgets, but because that disables support for enabling text input on sliders, can be set to True if needed.

@philippjfr
Copy link
Member Author

Ready to review/merge.

css = param.String(default=None, precedence=-1, doc="""
Defines the local CSS file to be loaded for this widget.""")
editable = param.Boolean(default=False, doc="""
Whether the slider text fields should be editable.""")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should mention the the reason it is disabled by default. It sounds useful, so there is a reason we want it off by default...

@jlstevens
Copy link
Contributor

Fairly short PR and other than updating the docstring, it looks good.

@jlstevens
Copy link
Contributor

Tests passing. Merging.

@jlstevens jlstevens merged commit 688c71c into master Apr 7, 2017
@philippjfr philippjfr deleted the bokeh_widgets_editable branch April 11, 2017 12:19
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants