-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added bokeh VectorField plot #1196
Conversation
Personally, I think the direction (and not just the angle) is a pretty important part of the semantics of 'vector'. I'm now undecided, @jbednar you have lots of experience with both orientation/vector fields..what do you think? |
I think it's better to have this than not to, so I'm happy to see it merged. But yes, I think having some way to figure out which end is which is a dealbreaker for the majority of uses of this plot. Can you file an issue with Bokeh about how to do the arrows, both in this case and for the Arrow annotation? I'm not sure what the underlying problem is. |
I'll try some ideas I have on this implementation, but bokeh's Arrow annotation is perfectly well defined, the issue is that our |
This is mainly because the holoviews |
Sorry wasn't clear, what I meant is that our arrow element only has an x, y location and a direction but what we really need is for it to specify the start and end points of the arrow so you can have arbitrary directions. Nothing to do with vector fields. |
Great! Looks like it was a bit more effort to get the arrows positioned properly (using 'segment' instead of 'ray') but I do think supporting arrows properly is worth it. |
78cfb43
to
128c3cd
Compare
Ready to merge. |
Tests are green. I'm glad I can merge it with proper arrow support - thanks! |
Excellent! Thanks for doing this! |
It does stand out there, doesn't it? :-) |
Probably ought to move Chart3D to the end of that list, btw; it's not the first thing people need, out of those items, and it's demotivating to see something unsupported as anything but the last thing in a list. |
Agreed, although I just updated the image, I'd left out all the charts. |
Right; I figured that out and updated my own comment to match. :-) 3D elements are definitely their own separate thing, not being easily overlaid like the rest are, so it makes sense in many ways to have them at the end. |
3D Elements are overlayable with other 3D Elements, and at least in matplotlib even 2D Elements, where the z-coordinate defaults to 0. |
I concur. |
Being able to overlay 2D Elements is cool; that should be mentioned at the start of the Charts3D section. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This completes compatibility for all chart plots, that only leaves the
Arrow
annotation and 3D Elements.