Matplotlib boxplot bug #1163
Merged
Matplotlib boxplot bug #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
type: bug
jlstevens
reviewed
Feb 27, 2017
holoviews/plotting/mpl/chart.py
Outdated
| style.pop('zorder') | ||
| style.pop('label') | ||
| style.pop('zorder', None) | ||
| style.pop('label', None) |
There was a problem hiding this comment.
None is the default if unset? If you just want to remove these keys we might want to switch to:
style = {k:v for k,v in style.items() if k not in ['zorder', 'label']}I might prefer this to using pop, especially as you aren't using the popped value(s).
philippjfr
force-pushed
the
mpl_chart_fixes
branch
from
959ba4a
to
cf0076a
Compare
|
Looks good. Merging. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BoxPlot raises an error when put in a Layout currently, small fix to ensure it doesn't. Also snuck in a style parameter for HistogramPlot.