Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop usages of len(Element) #1155

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Drop usages of len(Element) #1155

merged 1 commit into from
Feb 27, 2017

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 26, 2017

We've decided to avoid using len(Element) wherever possible.

@jlstevens
Copy link
Contributor

Happy to merge - I'm just wondering if these were new instances of len that are being removed again or whether these were missed in an earlier PR when we first discouraged using len...

@philippjfr
Copy link
Member Author

I think we just missed these, I've had this fix sitting in my stashes a while so possibly I just forgot to commit them at the time.

@jlstevens
Copy link
Contributor

Ok, looks good!

@jlstevens jlstevens merged commit fd65ac7 into master Feb 27, 2017
@philippjfr philippjfr deleted the no_length branch February 27, 2017 23:29
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants