Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed saving to html and json in Python 3 #1016

Merged
merged 4 commits into from
Dec 18, 2016
Merged

Conversation

philippjfr
Copy link
Member

Fixes #979 which ended up throwing bugs in Renderer.save in python3 when a string type was written to file. By defining the MIME type the encoding is applied correctly.

Needs some tests before merging.

@philippjfr philippjfr added type: bug Something isn't correct or isn't working status: WIP labels Dec 11, 2016
@philippjfr philippjfr changed the title Fixed rendering to html and json in Python 3 Fixed saving to html and json in Python 3 Dec 11, 2016
@jlstevens
Copy link
Contributor

Make sure to test this change with the archive functionality. If I remember right, there is code that needs to use the mime type to figure out how to encode the data (bytes vs strings).

@philippjfr
Copy link
Member Author

If I remember right, there is code that needs to use the mime type to figure out how to encode the data (bytes vs strings).

That's exactly the bit that was failing before I defined these. Will definitely test that.

@philippjfr
Copy link
Member Author

Ready once tests pass.

@jlstevens
Copy link
Contributor

Looks good. I'll merge now on the understanding that you did test this with hv.archive.

@jlstevens jlstevens merged commit bd283ec into master Dec 18, 2016
@philippjfr philippjfr deleted the renderer_mime_types branch January 7, 2017 15:00
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants