Fix popup positioning on polygons (#6411)

holoviz · Oct 15, 2024 · 21231c1 · 21231c1
1 parent 75888ac
commit 21231c1
Show file tree

Hide file tree

Showing 2 changed files with 53 additions and 5 deletions.
diff --git a/holoviews/plotting/bokeh/callbacks.py b/holoviews/plotting/bokeh/callbacks.py
@@ -1191,13 +1191,25 @@ def _watch_position(self):
               }
               if (!xs || !ys) { return }
               for (const i of indices) {
-                const tx = xs[i]
+                let ix = xs[i]
+                let iy = ys[i]
+                let tx, ty
+                if (typeof ix === 'number') {
+                  tx = ix
+                  ty = iy
+                } else {
+                  while (ix.length && (typeof ix[0] !== 'number')) {
+                    ix = ix[0]
+                    iy = iy[0]
+                  }
+                  tx = Math.max(...ix)
+                  ty = Math.max(...iy)
+                }
                 if (!x || (tx > x)) {
-                  x = xs[i]
+                  x = tx
                 }
-                const ty = ys[i]
                 if (!y || (ty > y)) {
-                  y = ys[i]
+                  y = ty
                 }
               }
               if (x && y) {

diff --git a/holoviews/tests/ui/bokeh/test_callback.py b/holoviews/tests/ui/bokeh/test_callback.py
@@ -262,7 +262,43 @@ def popup_form(name):
     hv_plot.click()
     expect(hv_plot).to_have_count(1)
 
-    locator = page.locator("#tap")
+    locator = page.locator(".markdown")
+    expect(locator).to_have_count(1)
+
+
+@skip_popup
+@pytest.mark.usefixtures("bokeh_backend")
+def test_stream_popup_polygons_tap(serve_hv):
+    def popup_form(name):
+        return f"# {name}"
+
+    points = hv.Polygons([(0, 0), (0, 1), (1, 1), (1, 0)]).opts(tools=["tap"])
+    hv.streams.Tap(source=points, popup=popup_form("Tap"))
+
+    page = serve_hv(points)
+    hv_plot = page.locator('.bk-events')
+    hv_plot.click()
+    expect(hv_plot).to_have_count(1)
+
+    locator = page.locator(".markdown")
+    expect(locator).to_have_count(1)
+
+
+@skip_popup
+@pytest.mark.usefixtures("bokeh_backend")
+def test_stream_popup_polygons_selection1d(serve_hv):
+    def popup_form(name):
+        return f"# {name}"
+
+    points = hv.Polygons([(0, 0), (0, 1), (1, 1), (1, 0)]).opts(tools=["tap"])
+    hv.streams.Selection1D(source=points, popup=popup_form("Tap"))
+
+    page = serve_hv(points)
+    hv_plot = page.locator('.bk-events')
+    hv_plot.click()
+    expect(hv_plot).to_have_count(1)
+
+    locator = page.locator(".markdown")
     expect(locator).to_have_count(1)