Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: Bokeh upper pin policy #776

Merged
merged 3 commits into from
Dec 16, 2024
Merged

compat: Bokeh upper pin policy #776

merged 3 commits into from
Dec 16, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 16, 2024

It is a pain to have a tight upper pin for Bokeh. This means we always need a release after a new Bokeh (and Panel) release.

Most of the code runs successfully without the custom models in GeoViews. So, this PR will add a warning if we are outside the range of the Bokeh version specified by the build-system and remove the upper pin.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 77.14286% with 8 lines in your changes missing coverage. Please review.

Project coverage is 69.82%. Comparing base (b0618a3) to head (2bef9a1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
geoviews/models/custom_tools.py 68.18% 7 Missing ⚠️
geoviews/tests/plotting/bokeh/test_models.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
+ Coverage   69.36%   69.82%   +0.46%     
==========================================
  Files          45       46       +1     
  Lines        4726     4756      +30     
==========================================
+ Hits         3278     3321      +43     
+ Misses       1448     1435      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro requested a review from philippjfr December 16, 2024 09:05
@philippjfr philippjfr merged commit 5f78ef6 into main Dec 16, 2024
16 checks passed
@philippjfr philippjfr deleted the compat_bokeh branch December 16, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants