Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: Support Bokeh 3.6 #750

Merged
merged 6 commits into from
Dec 16, 2024
Merged

compat: Support Bokeh 3.6 #750

merged 6 commits into from
Dec 16, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 27, 2024

With the release of Panel 1.5.1 this should now be possible.

@hoxbro hoxbro marked this pull request as draft September 27, 2024 15:36
@hoxbro
Copy link
Member Author

hoxbro commented Sep 28, 2024

Maybe failing install is related to bokeh/bokeh#14085.

@hoxbro hoxbro changed the title COMPAT: Support Bokeh 3.6 compat: Support Bokeh 3.6 Oct 1, 2024
@mattpap
Copy link
Collaborator

mattpap commented Nov 21, 2024

I fixed type errors in edit tools. I'm still investigating what to do about these tools in general. There are more differences between geoviews' and bokehjs' implementation that I originally expected.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.32%. Comparing base (4efca3b) to head (51f76dd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   69.34%   69.32%   -0.03%     
==========================================
  Files          45       45              
  Lines        4721     4721              
==========================================
- Hits         3274     3273       -1     
- Misses       1447     1448       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pyproject.toml Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
# Conflicts:
#	geoviews/package-lock.json
@hoxbro hoxbro marked this pull request as ready for review December 16, 2024 08:07
@hoxbro hoxbro merged commit ee088ab into main Dec 16, 2024
13 checks passed
@hoxbro hoxbro deleted the bokeh_36 branch December 16, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants