Added project_points and general project operation #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jlstevens Since you were using this you can review it too. It's ready to merge. |
jlstevens
reviewed
Jun 10, 2017
| @@ -19,13 +19,38 @@ class project_shape(ElementOperation): | |||
| instantiate=False, doc=""" | |||
| Projection the shape type is projected to.""") | |||
|
|
|||
| supported_types = [Shape, Polygons, Path] | |||
There was a problem hiding this comment.
We really need to find a way to standardize this sort of thing...
|
I'm happy to merge as the tests are passing and the operation worked correctly when I used it. That said, would you like to add a few unit tests before I merge? |
|
I'd like to but not today, and I need to push a new geoviews release out. Just going to merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
project_pointsoperation and a general operation which applies the appropriate project operation for each Element type.