added World_Physical_Map, World_Shaded_Relief and World_Topo_Map from ESRI #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks! Are there any others there that we are missing? The more the merrier! |
|
Yes, there are more. I can go through them all and add anything missing in a separate pull request this weekend. |
|
@jbednar - that should be all of them! |
|
Thanks for adding all those! I'm wondering if we should loop through tile_sources dict and refactor this so others know this exists: |
|
I created an issue to track the examples; we can just merge what you have currently. Thanks! |
ahuang11
pushed a commit
that referenced
this pull request
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added World_Physical_Map, World_Shaded_Relief and World_Topo_Map tile sources from ESRI