Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building with pip install #579

Merged
merged 8 commits into from
Jul 14, 2022
Merged

Fix building with pip install #579

merged 8 commits into from
Jul 14, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jul 14, 2022

Same as #578, but moved the branch to the main repo and away from my fork.

@maximlt
Copy link
Member

maximlt commented Jul 14, 2022

I've had to re-add the 'build' extra group in the setup.py file, it's needed by the conda recipe:

host:
- python {{ sdata['python_requires'] }}
{% for dep in sdata['extras_require']['build'] %}

I imagine there's a way for conda-build to pull the dependencies from the pyproject.toml file, I'd keep that for some later work on updating pyctdev.

I ran the docs and build workflows from this PR and they ran fine, merging then, thanks Simon!

@maximlt maximlt merged commit 41a5abb into master Jul 14, 2022
@maximlt maximlt deleted the fix_build branch July 14, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants