Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis CI build and run/lint/verify examples #508

Merged
merged 11 commits into from
Oct 23, 2017

Conversation

jbcrail
Copy link
Contributor

@jbcrail jbcrail commented Oct 23, 2017

While working on the newest release, I took a prior notebook verification tool that I wrote and combined it with @ceball's previous work in #463 to improve our Travis build and testing of the example notebooks. Here is a summary of the changes:

  • We can now lint, verify, and execute any notebook. The lint and verify tools are used in Travis CI, while the notebooks can be executed locally since the full datasets are still required. All notebooks are tested using the examples environment.
  • I refactored the Travis CI scripts, which can also be ran locally. The Xcode environment variable is no longer shown during Linux builds. I heavily borrowed Bokeh's CI setup.
  • I fixed several notebooks using the new verify mode (broken URLs, unused imports, etc).

We could later split the examples/nb CLI into a separate repo to share between projects.

Related to #407, #463

@jbcrail jbcrail requested a review from jbednar October 23, 2017 18:10
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is a clear improvement, so I'll merge it, but I hope that nearly all of this can be deleted very soon. We already have prototypes of code to do most of this in ways that don't have to be duplicated across projects, and we're maintaining so many simultaneous projects that I don't want to have any more boilerplate per project than we absolutely have to.

@jbednar jbednar merged commit 95ff99f into master Oct 23, 2017
@jbednar jbednar deleted the run-lint-verify-notebook branch October 23, 2017 21:46
jbednar pushed a commit that referenced this pull request Oct 30, 2017
* Add CLI to run/lint/verify notebook examples

* Remove unused imports and fix broken URLs

* Fix dependencies

* Refactor Travis CI setup into separate scripts, based on Bokeh's CI setup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants