Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove topics page replaced by a link to examples.holoviz.org #1377

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Dec 9, 2024

The topics page wasn't very pretty and was basically a bunch of links to examples.holoviz.org, except Amazon.com center distance that was linking to https://anaconda.org/defusco/amz_centers/notebook that is no longer available. With this PR it's replaced by an external link to examples.holoviz.org that has even more examples using datashader than originally listed on the topics page.

image

This introduces sphinx-reredirects as a docs dependency instead of sphinx rediraffe as the latter doesn't allow redirecting to an external URL unfortunately.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (7a99f49) to head (3643dfe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1377   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files          93       93           
  Lines       18707    18707           
=======================================
  Hits        16541    16541           
  Misses       2166     2166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amaloney
Copy link
Collaborator

amaloney commented Dec 9, 2024

Does examples.holoviz.org contain all the examples that were originally on the topics page?

@maximlt
Copy link
Member Author

maximlt commented Dec 9, 2024

Yes, except Amazon.com center distance that was linking to https://anaconda.org/defusco/amz_centers/notebook, link that is no longer available.

Copy link
Collaborator

@amaloney amaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hoxbro hoxbro merged commit 61f965b into main Dec 12, 2024
12 checks passed
@hoxbro hoxbro deleted the doc_examples_holoviz branch December 12, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants