-
-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fail-fast for datasets outside the visible extent #1345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1345 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.01%
==========================================
Files 92 92
Lines 18579 18582 +3
==========================================
+ Hits 16779 16781 +2
- Misses 1800 1801 +1 ☔ View full report in Codecov by Sentry. |
Awesome! Thanks for the really quick response! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the contribution! I can't spot any reason not to merge this.
Nice! Thanks for having a look! As i see it, the only drawback that might be relevant is that coordinate limits are now always evaluated while before it was possible to circuumvent the evaluation by passing explicit values for |
Seems like an OK tradeoff to me. |
While trying to improve datashader integration with EOmaps I ran into the following problem:
At the moment,
DSArtist.make_image()
does not check if the data is actually contained within the visible extent before attempting to create an image.This results in a huge performance penalty if a large number of datasets are present in a figure but only a few are actually in the visible extent. (e.g. during pan-zoom etc.)
This PR addresses this issue by evaluating the data-bbox on
DSArtist
initialization and then using it to fast-exitDSArtist.make_image()
in case no data is in the extent.