Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test run #1340

Merged
merged 19 commits into from
May 30, 2024
Merged

Update test run #1340

merged 19 commits into from
May 30, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 23, 2024

  • Remove the pip tests to reduce the maintenance burden
  • Remove the pyctdev lint step, as this is already handled by pre-commit; this makes it so we can remove a couple of packages.
  • Update codecov as it no longer works with their package.

Built on top of #1338

@hoxbro hoxbro changed the title Remove pip tests Update test run May 23, 2024
@hoxbro hoxbro marked this pull request as ready for review May 23, 2024 10:30
@maximlt
Copy link
Member

maximlt commented May 23, 2024

Remove the pip tests to reduce the maintenance burden

Did the pip tests fail more than the conda tests?

@hoxbro hoxbro force-pushed the update_test_run branch 3 times, most recently from 9335d58 to 6206825 Compare May 27, 2024 06:32
Base automatically changed from parallel to main May 30, 2024 08:41
@hoxbro
Copy link
Member Author

hoxbro commented May 30, 2024

Did the pip tests fail more than the conda tests?

No, one of the primary reasons it was added to test Python 3.12, which is now also tested in the other test.

Datashaders CI is also pretty intensive, testing every supported Python version on all platforms. I have noticed it can block the rest of our CI.

@hoxbro hoxbro merged commit 0cdbd43 into main May 30, 2024
19 checks passed
@hoxbro hoxbro deleted the update_test_run branch May 30, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants