Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download data script #1326

Merged
merged 10 commits into from
May 30, 2024
Merged

Add download data script #1326

merged 10 commits into from
May 30, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 1, 2024

Fixes #1325

@hoxbro hoxbro force-pushed the download_data_script branch from 0e7c126 to 35b6f82 Compare May 1, 2024 15:41
@hoxbro hoxbro force-pushed the download_data_script branch from 35b6f82 to 0d24abc Compare May 1, 2024 15:43
@hoxbro
Copy link
Member Author

hoxbro commented May 1, 2024

I have built the documents again from this PR. Which fixes the problem in the issue.

image

@hoxbro
Copy link
Member Author

hoxbro commented May 20, 2024

need to update to work with bokeh_sampledata

@hoxbro hoxbro added this to the v0.16.2 milestone May 20, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.58%. Comparing base (7c1111c) to head (216bf0e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1326   +/-   ##
=======================================
  Coverage   85.58%   85.58%           
=======================================
  Files          51       51           
  Lines       11290    11289    -1     
=======================================
  Hits         9662     9662           
+ Misses       1628     1627    -1     

@hoxbro hoxbro requested a review from jbednar May 21, 2024 17:15
@philippjfr
Copy link
Member

What's the longer term plan? Should the pyct commands in datashader/__init__.py be removed?

@hoxbro
Copy link
Member Author

hoxbro commented May 30, 2024

What's the longer term plan?

This only collects all the download data procedures in one place, it is heavily focused on the developer experience. pyct is still used.

I think longer term pyct should be replaced by hvsampledata.

@hoxbro hoxbro merged commit 6d84b96 into main May 30, 2024
1 of 2 checks passed
@hoxbro hoxbro deleted the download_data_script branch May 30, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polygon User Guide Long CSV Download Output
2 participants