Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1216.
Summary of fixes:
Conversion of float array containing NaN to integer:
np.nan_to_number
to convertnp.nan
to0
, which is the number that has always been returned in this scenario.category_binning
already determines a mask of the NaN values, so those NaN values are set to 0 (they could be any valid finite number) before the conversion to int.Canvas.raster
we avoid the warning by using afill_value
of0
for integerdtype
s as that is what the docstring says is used in this scenario.Warnings about finding max or min of an "all-nan slice" are specifically ignored as they already return the expected value of
nan
in this situation.