Return early in eq_hist() if all data masked out #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
approved these changes
Jan 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #1168 +/- ##
=======================================
Coverage 85.40% 85.40%
=======================================
Files 35 35
Lines 7987 7989 +2
=======================================
+ Hits 6821 6823 +2
Misses 1166 1166
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1166.
If pass an fully-masked array to
eq_hist()function, return early with an array ofNaNs. This avoids calculating the cumulative distribution function of no data and the resultantIndexErrorbecause the CDF has no contents.Passes new test locally on both CPU and GPU.