Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA support for where reduction #1167

Merged
merged 1 commit into from
Jan 23, 2023
Merged

CUDA support for where reduction #1167

merged 1 commit into from
Jan 23, 2023

Conversation

ianthomas23
Copy link
Member

This adds CUDA support (cudf and dask-cudf) for the new where reduction, for both possible approaches of referencing a named column of the dataframe and using the virtual row index of the dataframe.

Support only covers where(min) and where(max). CPU also supports where(first) and where(last) but there has never been support for first and last on the GPU due to the massively-parallel implementation not knowing the order of the dataframe rows. I note in passing that this is now feasible using the virtual row index idea as, for example, first is equivalent to min using the virtual row index. But that is future work!

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #1167 (575a1bb) into main (73d3deb) will decrease coverage by 0.05%.
The diff coverage is 68.51%.

@@            Coverage Diff             @@
##             main    #1167      +/-   ##
==========================================
- Coverage   85.40%   85.36%   -0.05%     
==========================================
  Files          35       35              
  Lines        7987     8006      +19     
==========================================
+ Hits         6821     6834      +13     
- Misses       1166     1172       +6     
Impacted Files Coverage Δ
datashader/reductions.py 85.99% <65.30%> (-0.46%) ⬇️
datashader/data_libraries/dask.py 95.00% <100.00%> (+0.04%) ⬆️
datashader/utils.py 76.84% <100.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 added this to the v0.14.4 milestone Jan 19, 2023
@ianthomas23 ianthomas23 merged commit 0ade086 into holoviz:main Jan 23, 2023
@ianthomas23 ianthomas23 deleted the where_reduction_cuda branch January 23, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant