Better validate canvas.line() coordinate lengths #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1160 +/- ##
==========================================
+ Coverage 85.38% 85.39% +0.01%
==========================================
Files 35 35
Lines 7812 7820 +8
==========================================
+ Hits 6670 6678 +8
Misses 1142 1142
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I am merging this following review approval. There is a CI problem with Python 3.7 on macos but that is affecting all PRs and I will address it as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1159.
This adds extra checks in the
validate()functions of the various line classes such asLinesAxis1XConstantto check that the suppliedxandycoordinates have the same lengths.