Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1130.
This simplifies the
test_gpu
flag so that it is boolean. Previously it could beTrue
,False
orNone
(meaning unspecified) and theNone
option was supposed to behave the same asFalse
but with different test skipped messages. But it wasn't handled consistently, now it is. It still defaults to not running GPU tests. I am not sure this is the best default, but it can be dealt with in a later PR.On a system with a GPU and with
cupy
andcudf
installed, running the tests in either of these ways runs exactly the same tests (i.e. ignores the all GPU tests):and to run all tests including GPU ones use
Also tested all 3 options in an environment without
cupy
andcudf
installed, and if you setDATASHADER_TEST_GPU=1
then thetest_gpu_dependencies
test fails as expected.After this PR, all tests run on CPU and GPU on my dev machine (Ubuntu 22.04 x86_64, Nvidia Quadro T1000) with the exception of that identified in issue #1131, which can be manually disabled using the
-k "not log_axis_line"
command-line argument.