Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1128.
Solution is to replace all
numpy
calls ineq_hist()
with equivalentcupy
calls so that the data remains on the GPU.There are already tests that cover this but they do not occur in github CI so I have tested them locally. One
cupy
test produces slightly different results (red component changed by 1) thannumpy
due to different numerics incupy
.After this, the following passes locally: