Ensure spatial index _sindex is retained on dataframe copy #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbednar
reviewed
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1121.
The fix is to copy the
_sindexif it is not copied automatically when we slice aDataFrame. We should probably consider this a temporary solution as the full solution would occur inspatialpandas, but with possible changes due to use ofawkward-pandaswe should hold off on that for the moment.It wasn't possible to directly access the problem code as it occurred within a
bypixelcall. So I have pulled out the conversion code into a_bypixel_sanitisefunction which is tested on its own in the newtest_spatial_index_not_droppedtest.